Chore(mypy): Annotate None returns for typing improvements (#11213)

This commit is contained in:
Sebastian Steinbeißer authored and GitHub committed 2026-02-02 08:44:12 -08:00
1 parent a9c0b06e28
commit 3b5ffbf9fa
113 files changed
+1598 -1510

No files matched your search

+13 -13
View File
@@ -18,7 +18,7 @@ from paperless.adapter import DrfTokenStrategy
class TestCustomAccountAdapter(TestCase):
def test_is_open_for_signup(self):
def test_is_open_for_signup(self) -> None:
adapter = get_adapter()
# With no accounts, signups should be allowed
@@ -34,7 +34,7 @@ class TestCustomAccountAdapter(TestCase):
settings.ACCOUNT_ALLOW_SIGNUPS = False
self.assertFalse(adapter.is_open_for_signup(None))
def test_is_safe_url(self):
def test_is_safe_url(self) -> None:
request = HttpRequest()
request.get_host = mock.Mock(return_value="example.com")
with context.request_context(request):
@@ -59,7 +59,7 @@ class TestCustomAccountAdapter(TestCase):
self.assertFalse(adapter.is_safe_url(url))
@mock.patch("allauth.core.internal.ratelimit.consume", return_value=True)
def test_pre_authenticate(self, mock_consume):
def test_pre_authenticate(self, mock_consume) -> None:
adapter = get_adapter()
request = HttpRequest()
request.get_host = mock.Mock(return_value="example.com")
@@ -71,7 +71,7 @@ class TestCustomAccountAdapter(TestCase):
with self.assertRaises(ValidationError):
adapter.pre_authenticate(request)
def test_get_reset_password_from_key_url(self):
def test_get_reset_password_from_key_url(self) -> None:
request = HttpRequest()
request.get_host = mock.Mock(return_value="foo.org")
with context.request_context(request):
@@ -93,7 +93,7 @@ class TestCustomAccountAdapter(TestCase):
)
@override_settings(ACCOUNT_DEFAULT_GROUPS=["group1", "group2"])
def test_save_user_adds_groups(self):
def test_save_user_adds_groups(self) -> None:
Group.objects.create(name="group1")
user = User.objects.create_user("testuser")
adapter = get_adapter()
@@ -110,7 +110,7 @@ class TestCustomAccountAdapter(TestCase):
self.assertTrue(user.groups.filter(name="group1").exists())
self.assertFalse(user.groups.filter(name="group2").exists())
def test_fresh_install_save_creates_superuser(self):
def test_fresh_install_save_creates_superuser(self) -> None:
adapter = get_adapter()
form = mock.Mock(
cleaned_data={
@@ -133,7 +133,7 @@ class TestCustomAccountAdapter(TestCase):
class TestCustomSocialAccountAdapter(TestCase):
def test_is_open_for_signup(self):
def test_is_open_for_signup(self) -> None:
adapter = get_social_adapter()
# Test when SOCIALACCOUNT_ALLOW_SIGNUPS is True
@@ -144,7 +144,7 @@ class TestCustomSocialAccountAdapter(TestCase):
settings.SOCIALACCOUNT_ALLOW_SIGNUPS = False
self.assertFalse(adapter.is_open_for_signup(None, None))
def test_get_connect_redirect_url(self):
def test_get_connect_redirect_url(self) -> None:
adapter = get_social_adapter()
request = None
socialaccount = None
@@ -157,7 +157,7 @@ class TestCustomSocialAccountAdapter(TestCase):
)
@override_settings(SOCIAL_ACCOUNT_DEFAULT_GROUPS=["group1", "group2"])
def test_save_user_adds_groups(self):
def test_save_user_adds_groups(self) -> None:
Group.objects.create(name="group1")
adapter = get_social_adapter()
request = HttpRequest()
@@ -172,7 +172,7 @@ class TestCustomSocialAccountAdapter(TestCase):
self.assertTrue(user.groups.filter(name="group1").exists())
self.assertFalse(user.groups.filter(name="group2").exists())
def test_error_logged_on_authentication_error(self):
def test_error_logged_on_authentication_error(self) -> None:
adapter = get_social_adapter()
request = HttpRequest()
with self.assertLogs("paperless.auth", level="INFO") as log_cm:
@@ -188,7 +188,7 @@ class TestCustomSocialAccountAdapter(TestCase):
class TestDrfTokenStrategy(TestCase):
def test_create_access_token_creates_new_token(self):
def test_create_access_token_creates_new_token(self) -> None:
"""
GIVEN:
- A user with no existing DRF token
@@ -213,7 +213,7 @@ class TestDrfTokenStrategy(TestCase):
token = Token.objects.get(user=user)
self.assertEqual(token_key, token.key)
def test_create_access_token_returns_existing_token(self):
def test_create_access_token_returns_existing_token(self) -> None:
"""
GIVEN:
- A user with an existing DRF token
@@ -238,7 +238,7 @@ class TestDrfTokenStrategy(TestCase):
# Verify only one token exists (no duplicate created)
self.assertEqual(Token.objects.filter(user=user).count(), 1)
def test_create_access_token_returns_none_for_unauthenticated_user(self):
def test_create_access_token_returns_none_for_unauthenticated_user(self) -> None:
"""
GIVEN:
- An unauthenticated request