Chore(mypy): Annotate None returns for typing improvements (#11213)

This commit is contained in:
Sebastian Steinbeißer
2026-02-02 17:44:12 +01:00
committed by GitHub
parent a9c0b06e28
commit 3b5ffbf9fa
113 changed files with 1598 additions and 1510 deletions
+11 -11
View File
@@ -17,7 +17,7 @@ from documents.tests.utils import SampleDirMixin
class TestEmail(DirectoriesMixin, SampleDirMixin, APITestCase):
ENDPOINT = "/api/documents/email/"
def setUp(self):
def setUp(self) -> None:
super().setUp()
self.user = User.objects.create_superuser(username="temp_admin")
@@ -58,7 +58,7 @@ class TestEmail(DirectoriesMixin, SampleDirMixin, APITestCase):
EMAIL_ENABLED=True,
EMAIL_BACKEND="django.core.mail.backends.locmem.EmailBackend",
)
def test_email_success(self):
def test_email_success(self) -> None:
"""
GIVEN:
- Multiple existing documents (doc1 with archive, doc2 without)
@@ -113,7 +113,7 @@ class TestEmail(DirectoriesMixin, SampleDirMixin, APITestCase):
EMAIL_ENABLED=True,
EMAIL_BACKEND="django.core.mail.backends.locmem.EmailBackend",
)
def test_email_use_original_version(self):
def test_email_use_original_version(self) -> None:
"""
GIVEN:
- Documents with archive versions
@@ -145,7 +145,7 @@ class TestEmail(DirectoriesMixin, SampleDirMixin, APITestCase):
original_size = self.doc1.source_path.stat().st_size
self.assertEqual(len(attachment[1]), original_size)
def test_email_missing_required_fields(self):
def test_email_missing_required_fields(self) -> None:
"""
GIVEN:
- Request with missing required fields
@@ -210,7 +210,7 @@ class TestEmail(DirectoriesMixin, SampleDirMixin, APITestCase):
)
self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)
def test_email_empty_document_list(self):
def test_email_empty_document_list(self) -> None:
"""
GIVEN:
- Request with empty document list
@@ -233,7 +233,7 @@ class TestEmail(DirectoriesMixin, SampleDirMixin, APITestCase):
)
self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)
def test_email_invalid_document_id(self):
def test_email_invalid_document_id(self) -> None:
"""
GIVEN:
- Request with non-existent document ID
@@ -256,7 +256,7 @@ class TestEmail(DirectoriesMixin, SampleDirMixin, APITestCase):
)
self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)
def test_email_invalid_email_address(self):
def test_email_invalid_email_address(self) -> None:
"""
GIVEN:
- Request with invalid email address
@@ -294,7 +294,7 @@ class TestEmail(DirectoriesMixin, SampleDirMixin, APITestCase):
)
self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)
def test_email_insufficient_permissions(self):
def test_email_insufficient_permissions(self) -> None:
"""
GIVEN:
- User without permissions to view document
@@ -329,7 +329,7 @@ class TestEmail(DirectoriesMixin, SampleDirMixin, APITestCase):
)
self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN)
def test_email_only_requires_view_permission(self):
def test_email_only_requires_view_permission(self) -> None:
"""
GIVEN:
- User having only view documents permission
@@ -361,7 +361,7 @@ class TestEmail(DirectoriesMixin, SampleDirMixin, APITestCase):
EMAIL_ENABLED=True,
EMAIL_BACKEND="django.core.mail.backends.locmem.EmailBackend",
)
def test_email_duplicate_filenames(self):
def test_email_duplicate_filenames(self) -> None:
"""
GIVEN:
- Multiple documents with the same title
@@ -414,7 +414,7 @@ class TestEmail(DirectoriesMixin, SampleDirMixin, APITestCase):
"django.core.mail.message.EmailMessage.send",
side_effect=Exception("Email error"),
)
def test_email_send_error(self, mocked_send):
def test_email_send_error(self, mocked_send) -> None:
"""
GIVEN:
- Existing documents