From 2a8579f610824b26a6997d01673bba3c70c0bf5e Mon Sep 17 00:00:00 2001 From: shamoon <4887959+shamoon@users.noreply.github.com> Date: Wed, 12 Aug 2026 14:19:21 -0700 Subject: [PATCH] Fix: include sharelink bundle perms in WebUI (#13664) --- .../permissions-select.component.spec.ts | 9 +++++++++ src-ui/src/app/services/permissions.service.spec.ts | 10 ++++++++++ src-ui/src/app/services/permissions.service.ts | 1 + 3 files changed, 20 insertions(+) diff --git a/src-ui/src/app/components/common/permissions-select/permissions-select.component.spec.ts b/src-ui/src/app/components/common/permissions-select/permissions-select.component.spec.ts index 7f2313a9b..dd82cdac5 100644 --- a/src-ui/src/app/components/common/permissions-select/permissions-select.component.spec.ts +++ b/src-ui/src/app/components/common/permissions-select/permissions-select.component.spec.ts @@ -17,6 +17,10 @@ const permissions = [ 'view_document', 'change_document', 'delete_document', + 'add_sharelinkbundle', + 'view_sharelinkbundle', + 'change_sharelinkbundle', + 'delete_sharelinkbundle', 'change_tag', 'view_documenttype', ] @@ -75,6 +79,7 @@ describe('PermissionsSelectComponent', () => { component.ngOnInit() component.writeValue(permissions) expect(component.typesWithAllActions).toContain('Document') + expect(component.typesWithAllActions).toContain('ShareLinkBundle') }) it('should update checkboxes on permissions set', () => { @@ -85,6 +90,10 @@ describe('PermissionsSelectComponent', () => { expect(input1.nativeElement.checked).toBeTruthy() const input2 = fixture.debugElement.query(By.css('input#Tag_Change')) expect(input2.nativeElement.checked).toBeTruthy() + const bundleInput = fixture.debugElement.query( + By.css('input#ShareLinkBundle_Add') + ) + expect(bundleInput.nativeElement.checked).toBeTruthy() }) it('disable checkboxes when permissions are inherited', () => { diff --git a/src-ui/src/app/services/permissions.service.spec.ts b/src-ui/src/app/services/permissions.service.spec.ts index 86c878545..f3529e080 100644 --- a/src-ui/src/app/services/permissions.service.spec.ts +++ b/src-ui/src/app/services/permissions.service.spec.ts @@ -120,6 +120,12 @@ describe('PermissionsService', () => { actionKey: 'View', // PermissionAction.View typeKey: 'SystemMonitoring', // PermissionType.SystemMonitoring }) + expect(permissionsService.getPermissionKeys('add_sharelinkbundle')).toEqual( + { + actionKey: 'Add', // PermissionAction.Add + typeKey: 'ShareLinkBundle', // PermissionType.ShareLinkBundle + } + ) }) it('correctly checks explicit global permissions', () => { @@ -269,6 +275,10 @@ describe('PermissionsService', () => { 'view_sharelink', 'change_sharelink', 'delete_sharelink', + 'add_sharelinkbundle', + 'view_sharelinkbundle', + 'change_sharelinkbundle', + 'delete_sharelinkbundle', 'add_workflow', 'view_workflow', 'change_workflow', diff --git a/src-ui/src/app/services/permissions.service.ts b/src-ui/src/app/services/permissions.service.ts index 198df0a35..673ade716 100644 --- a/src-ui/src/app/services/permissions.service.ts +++ b/src-ui/src/app/services/permissions.service.ts @@ -26,6 +26,7 @@ export enum PermissionType { User = '%s_user', Group = '%s_group', ShareLink = '%s_sharelink', + ShareLinkBundle = '%s_sharelinkbundle', CustomField = '%s_customfield', Workflow = '%s_workflow', ProcessedMail = '%s_processedmail',