From 263b1423a8e723de6d15b225ce316e7bf927c926 Mon Sep 17 00:00:00 2001 From: stumpylog <797416+stumpylog@users.noreply.github.com> Date: Fri, 31 Jul 2026 09:28:39 -0700 Subject: [PATCH] perf: drop unused select_related("owner") from email_documents The permission check loop that used to call has_perms_owner_aware() (which read .owner) was already replaced with permitted_document_ids() resolved once into a set. No other code in email_documents touches .owner, so the select_related is dead weight. --- src/documents/views.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/documents/views.py b/src/documents/views.py index d40332925..a29faf90f 100644 --- a/src/documents/views.py +++ b/src/documents/views.py @@ -1929,7 +1929,7 @@ class DocumentViewSet( message = validated_data.get("message") use_archive_version = validated_data.get("use_archive_version", True) - documents = Document.objects.select_related("owner").filter(pk__in=document_ids) + documents = Document.objects.filter(pk__in=document_ids) if request.user is not None: permitted_ids = set(permitted_document_ids(request.user)) if not all(document.pk in permitted_ids for document in documents):