From 1d75457e3d74b0b5e9396492d39d7fc9f6a88df4 Mon Sep 17 00:00:00 2001 From: shamoon <4887959+shamoon@users.noreply.github.com> Date: Sun, 9 Aug 2026 20:21:01 -0700 Subject: [PATCH] Also fix this setting false/0 from the frontend --- .../custom-fields-values.component.spec.ts | 8 ++++---- .../custom-fields-values.component.ts | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src-ui/src/app/components/common/input/custom-fields-values/custom-fields-values.component.spec.ts b/src-ui/src/app/components/common/input/custom-fields-values/custom-fields-values.component.spec.ts index 82a065452..a50511f55 100644 --- a/src-ui/src/app/components/common/input/custom-fields-values/custom-fields-values.component.spec.ts +++ b/src-ui/src/app/components/common/input/custom-fields-values/custom-fields-values.component.spec.ts @@ -52,10 +52,10 @@ describe('CustomFieldsValuesComponent', () => { }) it('should set selectedFields and map values correctly', () => { - component.value = { 1: 'value1' } - component.selectedFields = [1, 2] - expect(component.selectedFields).toEqual([1, 2]) - expect(component.value).toEqual({ 1: 'value1', 2: null }) + component.value = { 1: 'value1', 3: 0, 4: false } + component.selectedFields = [1, 2, 3, 4] + expect(component.selectedFields).toEqual([1, 2, 3, 4]) + expect(component.value).toEqual({ 1: 'value1', 2: null, 3: 0, 4: false }) }) it('should return the correct custom field by id', () => { diff --git a/src-ui/src/app/components/common/input/custom-fields-values/custom-fields-values.component.ts b/src-ui/src/app/components/common/input/custom-fields-values/custom-fields-values.component.ts index 837f43026..65a2bea8a 100644 --- a/src-ui/src/app/components/common/input/custom-fields-values/custom-fields-values.component.ts +++ b/src-ui/src/app/components/common/input/custom-fields-values/custom-fields-values.component.ts @@ -77,7 +77,7 @@ export class CustomFieldsValuesComponent extends AbstractInputComponent this._selectedFields = newFields // map the selected fields to an object with field_id as key and value as value this.value = newFields.reduce((acc, fieldId) => { - acc[fieldId] = this.value?.[fieldId] || null + acc[fieldId] = this.value?.[fieldId] ?? null return acc }, {}) this.onChange(this.value)