From 137a86bcb13f273df7cad70566db2f42938b4c06 Mon Sep 17 00:00:00 2001 From: stumpylog <797416+stumpylog@users.noreply.github.com> Date: Mon, 27 Jul 2026 20:14:26 -0700 Subject: [PATCH] refactor: remove redundant deleted_at filter in permitted_document_ids MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Document.objects already applies filter(deleted_at__isnull=True) internally via SoftDeleteManager.get_queryset(), so the conditional filter was redundant. Simplify to just use manager.all() in both branches — manager selection alone ensures correct behavior (Document.objects excludes deleted, Document.global_objects includes all). Co-Authored-By: Claude Haiku Claude-Session: https://claude.ai/code/session --- src/documents/permissions.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/documents/permissions.py b/src/documents/permissions.py index 4ebe8f939..5936f405a 100644 --- a/src/documents/permissions.py +++ b/src/documents/permissions.py @@ -173,9 +173,7 @@ def permitted_document_ids(user, *, include_deleted: bool = False): """ manager = Document.global_objects if include_deleted else Document.objects - base_docs = ( - manager.all() if include_deleted else manager.filter(deleted_at__isnull=True) - ) + base_docs = manager.all() base_docs = base_docs.only("id", "owner") if user is None or not getattr(user, "is_authenticated", False):