From 1326378a903dff07ea946d3abc8ae14f13c81ae9 Mon Sep 17 00:00:00 2001 From: Trenton H <797416+stumpylog@users.noreply.github.com> Date: Mon, 16 Nov 2026 07:18:53 -0800 Subject: [PATCH] Chore: remove unused is_file_ext_supported Nothing in production called it, only its own test. --- src/documents/parsers.py | 11 ----------- src/documents/tests/test_parsers.py | 6 ------ 2 files changed, 17 deletions(-) diff --git a/src/documents/parsers.py b/src/documents/parsers.py index 48983bb232..d5aa48fca3 100644 --- a/src/documents/parsers.py +++ b/src/documents/parsers.py @@ -44,17 +44,6 @@ def get_default_file_extension(mime_type: str) -> str: return ext if ext else "" -def is_file_ext_supported(ext: str) -> bool: - """ - Returns True if the file extension is supported, False otherwise - TODO: Investigate why this really exists, why not use mimetype - """ - if ext: - return ext.lower() in get_supported_file_extensions() - else: - return False - - def get_supported_file_extensions() -> set[str]: extensions = set() for parser_class in get_parser_registry().all_parsers(): diff --git a/src/documents/tests/test_parsers.py b/src/documents/tests/test_parsers.py index cf27994c10..16fe5d14e6 100644 --- a/src/documents/tests/test_parsers.py +++ b/src/documents/tests/test_parsers.py @@ -14,7 +14,6 @@ from documents.parsers import encode_thumbnail_webp from documents.parsers import get_default_file_extension from documents.parsers import get_default_thumbnail from documents.parsers import get_supported_file_extensions -from documents.parsers import is_file_ext_supported from documents.parsers import make_thumbnail_from_pdf from documents.parsers import rasterize_pdf_page_to_png from paperless.parsers.registry import get_parser_registry @@ -132,11 +131,6 @@ class TestParserAvailability: # Test invalid mimetype returns no extension assert get_default_file_extension("aasdasd/dgfgf") == "" - def test_file_extension_support(self) -> None: - assert is_file_ext_supported(".pdf") - assert not is_file_ext_supported(".hsdfh") - assert not is_file_ext_supported("") - class TestComputeThumbnailDpi: @pytest.mark.parametrize(