From 0e94d4ee384fc9107ab2374ad82b78c7910063b4 Mon Sep 17 00:00:00 2001 From: Trenton H <797416+stumpylog@users.noreply.github.com> Date: Wed, 25 Mar 2026 13:59:41 -0700 Subject: [PATCH] Don't silently drop the change_groups and switch to a couple slightly more efficient implementations --- src/documents/consumer.py | 5 +++-- src/documents/tasks.py | 6 +++--- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/documents/consumer.py b/src/documents/consumer.py index 809d6c6476..e4fdea2ba2 100644 --- a/src/documents/consumer.py +++ b/src/documents/consumer.py @@ -1,6 +1,7 @@ import datetime import hashlib import os +import shutil import tempfile from enum import StrEnum from pathlib import Path @@ -833,7 +834,7 @@ class ConsumerPlugin( self.metadata.view_users is not None or self.metadata.view_groups is not None or self.metadata.change_users is not None - or self.metadata.change_users is not None + or self.metadata.change_groups is not None ): permissions = { "view": { @@ -866,7 +867,7 @@ class ConsumerPlugin( Path(source).open("rb") as read_file, Path(target).open("wb") as write_file, ): - write_file.write(read_file.read()) + shutil.copyfileobj(read_file, write_file) # Attempt to copy file's original stats, but it's ok if we can't try: diff --git a/src/documents/tasks.py b/src/documents/tasks.py index 751990c62f..20351a49d6 100644 --- a/src/documents/tasks.py +++ b/src/documents/tasks.py @@ -53,8 +53,8 @@ from documents.models import Tag from documents.models import WorkflowRun from documents.models import WorkflowTrigger from documents.plugins.base import ConsumeTaskPlugin -from documents.plugins.base import ProgressManager from documents.plugins.base import StopConsumeTaskError +from documents.plugins.helpers import ProgressManager from documents.plugins.helpers import ProgressStatusOptions from documents.sanity_checker import SanityCheckFailedException from documents.signals import document_updated @@ -533,13 +533,13 @@ def check_scheduled_workflows() -> None: id__in=matched_ids, ) - if documents.count() > 0: + if documents.exists(): documents = prefilter_documents_by_workflowtrigger( documents, trigger, ) - if documents.count() > 0: + if documents.exists(): logger.debug( f"Found {documents.count()} documents for trigger {trigger}", )