Chore: refactor loading stuff to be more DRY

src-ui/src/app/components/loading-component/loading.component.spec.ts

@@ -29,8 +29,8 @@ describe('LoadingComponentWithPermissions', () => {
     expect(component.loading).toBeTruthy()
   })
 
-  it('should have reveal set to false by default', () => {
-    expect(component.reveal).toBeFalsy()
+  it('should have show set to false by default', () => {
+    expect(component.show).toBeFalsy()
   })
 
   it('should call next and complete on unsubscribeNotifier with itself on destroy', () => {

src-ui/src/app/components/loading-component/loading.component.ts

@@ -8,7 +8,7 @@ export abstract class LoadingComponentWithPermissions
   implements OnDestroy
 {
   public loading: boolean = true
-  public reveal: boolean = false
+  public show: boolean = false
 
   protected unsubscribeNotifier: Subject<any> = new Subject()