Chore: Share the API client fixtures and build test users cheaply

src/documents/tests/test_api_custom_fields.py

@@ -4,7 +4,6 @@ from unittest import mock
 from unittest.mock import ANY
 
 from django.contrib.auth.models import Permission
-from django.contrib.auth.models import User
 from django.test import override_settings
 from guardian.shortcuts import assign_perm
 from rest_framework import status
@@ -14,13 +13,14 @@ from documents.models import CustomField
 from documents.models import CustomFieldInstance
 from documents.models import Document
 from paperless_testing.dirs import DirectoriesMixin
+from paperless_testing.factories import UserFactory
 
 
 class TestCustomFieldsAPI(DirectoriesMixin, APITestCase):
     ENDPOINT = "/api/custom_fields/"
 
     def setUp(self) -> None:
-        self.user = User.objects.create_superuser(username="temp_admin")
+        self.user = UserFactory(username="temp_admin", superuser=True)
         self.client.force_authenticate(user=self.user)
         return super().setUp()
 
@@ -1174,11 +1174,11 @@ class TestCustomFieldsAPI(DirectoriesMixin, APITestCase):
     def test_documentlink_patch_requires_change_permission_on_target_documents(
         self,
     ) -> None:
-        source_owner = User.objects.create_user(username="source-owner")
+        source_owner = UserFactory(username="source-owner")
         source_owner.user_permissions.add(
             Permission.objects.get(codename="change_document"),
         )
-        other_user = User.objects.create_user(username="other-user")
+        other_user = UserFactory(username="other-user")
 
         source_doc = Document.objects.create(
             title="Source",
@@ -1221,11 +1221,11 @@ class TestCustomFieldsAPI(DirectoriesMixin, APITestCase):
     def test_documentlink_patch_allowed_with_change_permission_on_target_documents(
         self,
     ) -> None:
-        source_owner = User.objects.create_user(username="source-owner")
+        source_owner = UserFactory(username="source-owner")
         source_owner.user_permissions.add(
             Permission.objects.get(codename="change_document"),
         )
-        other_user = User.objects.create_user(username="other-user")
+        other_user = UserFactory(username="other-user")
 
         source_doc = Document.objects.create(
             title="Source",
@@ -1337,7 +1337,7 @@ class TestCustomFieldsAPI(DirectoriesMixin, APITestCase):
         self.assertEqual(results[0]["document_count"], 1)
 
         # Test as user without access to the document
-        non_superuser = User.objects.create_user(username="non_superuser")
+        non_superuser = UserFactory(username="non_superuser")
         non_superuser.user_permissions.add(
             *Permission.objects.exclude(codename="view_global_statistics"),
         )