From 068fc4b8bc027018bc1884e01ab4bba18cccbd87 Mon Sep 17 00:00:00 2001 From: shamoon <4887959+shamoon@users.noreply.github.com> Date: Tue, 17 Nov 2026 23:27:21 -0800 Subject: [PATCH] This is better as a signal --- .../src/app/services/settings.service.spec.ts | 6 ++--- src-ui/src/app/services/settings.service.ts | 23 ++++++++++--------- 2 files changed, 15 insertions(+), 14 deletions(-) diff --git a/src-ui/src/app/services/settings.service.spec.ts b/src-ui/src/app/services/settings.service.spec.ts index 6c4cdb3493..ed9f93df3e 100644 --- a/src-ui/src/app/services/settings.service.spec.ts +++ b/src-ui/src/app/services/settings.service.spec.ts @@ -420,7 +420,7 @@ describe('SettingsService', () => { expect(req.request.body.settings.whats_new.last_seen_version).toEqual( '3.5.1' ) - expect(settingsService.unseenReleasesSince).toBeNull() + expect(settingsService.unseenReleasesSince()).toBeNull() }) it('reports unseen releases and marks them seen', () => { @@ -440,7 +440,7 @@ describe('SettingsService', () => { .flush(settings) httpTestingController.expectNone(`${environment.apiBaseUrl}ui_settings/`) - expect(settingsService.unseenReleasesSince).toEqual('3.4.2') + expect(settingsService.unseenReleasesSince()).toEqual('3.4.2') subscription = settingsService.markReleasesSeen().subscribe() const req = httpTestingController.expectOne( @@ -449,7 +449,7 @@ describe('SettingsService', () => { expect(req.request.body.settings.whats_new.last_seen_version).toEqual( '3.5.1' ) - expect(settingsService.unseenReleasesSince).toBeNull() + expect(settingsService.unseenReleasesSince()).toBeNull() }) it('updates settings on complete tour', () => { diff --git a/src-ui/src/app/services/settings.service.ts b/src-ui/src/app/services/settings.service.ts index ac7e6f9dda..2573f32d90 100644 --- a/src-ui/src/app/services/settings.service.ts +++ b/src-ui/src/app/services/settings.service.ts @@ -328,6 +328,18 @@ export class SettingsService { SETTINGS_KEYS.SIDEBAR_HIDDEN_ITEMS ) + /** + * The last version the user saw release notes for, if the running + * version is newer, or null. + */ + readonly unseenReleasesSince = computed(() => { + this.settingsVersion() + const currentVersion = this.get(SETTINGS_KEYS.VERSION) + const lastSeen = this.get(SETTINGS_KEYS.WHATS_NEW_LAST_SEEN_VERSION) + if (!currentVersion || !lastSeen) return null + return compareVersions(currentVersion, lastSeen) > 0 ? lastSeen : null + }) + readonly allDisplayFields = signal>( DEFAULT_DISPLAY_FIELDS ) @@ -735,17 +747,6 @@ export class SettingsService { .subscribe({ error: () => {} }) } - /** - * The last version the user saw release notes for, if the running - * version is newer, or null. - */ - public get unseenReleasesSince(): string | null { - const currentVersion = this.get(SETTINGS_KEYS.VERSION) - const lastSeen = this.get(SETTINGS_KEYS.WHATS_NEW_LAST_SEEN_VERSION) - if (!currentVersion || !lastSeen) return null - return compareVersions(currentVersion, lastSeen) > 0 ? lastSeen : null - } - public markReleasesSeen(): Observable { this.set( SETTINGS_KEYS.WHATS_NEW_LAST_SEEN_VERSION,