From 007316edf7cb8f1d9d5de39fd1fecf2a945374f4 Mon Sep 17 00:00:00 2001 From: shamoon <4887959+shamoon@users.noreply.github.com> Date: Sat, 5 Sep 2026 16:34:25 -0700 Subject: [PATCH] Fix the copy to not be a toast --- .../share-link-bundle-list.component.html | 71 ++++++++++--------- .../share-link-bundle-list.component.spec.ts | 10 ++- .../share-link-bundle-list.component.ts | 1 - 3 files changed, 48 insertions(+), 34 deletions(-) diff --git a/src-ui/src/app/components/manage/share-links/share-link-bundle-list/share-link-bundle-list.component.html b/src-ui/src/app/components/manage/share-links/share-link-bundle-list/share-link-bundle-list.component.html index 68ea5ba21..4f6392c80 100644 --- a/src-ui/src/app/components/manage/share-links/share-link-bundle-list/share-link-bundle-list.component.html +++ b/src-ui/src/app/components/manage/share-links/share-link-bundle-list/share-link-bundle-list.component.html @@ -99,42 +99,49 @@ {{ bundle.document_count }} {{ fileVersionLabel(bundle.file_version) }} -
- - @if (bundle.status === statuses.Failed) { +
+ Copied! +
- } - - Delete share link bundle - + @if (bundle.status === statuses.Failed) { + + } + + Delete share link bundle + +
diff --git a/src-ui/src/app/components/manage/share-links/share-link-bundle-list/share-link-bundle-list.component.spec.ts b/src-ui/src/app/components/manage/share-links/share-link-bundle-list/share-link-bundle-list.component.spec.ts index 3bdddda3d..6cd659f7d 100644 --- a/src-ui/src/app/components/manage/share-links/share-link-bundle-list/share-link-bundle-list.component.spec.ts +++ b/src-ui/src/app/components/manage/share-links/share-link-bundle-list/share-link-bundle-list.component.spec.ts @@ -122,16 +122,24 @@ describe('ShareLinkBundleListComponent', () => { slug: 'ready-slug', status: ShareLinkBundleStatus.Ready, }) + component.bundles.set([readyBundle]) + fixture.detectChanges() component.copy(readyBundle) expect(clipboard.copy).toHaveBeenCalledWith( component.getShareUrl(readyBundle) ) expect(component.copiedSlug()).toBe('ready-slug') - expect(toastService.showInfo).toHaveBeenCalled() + expect(toastService.showInfo).not.toHaveBeenCalled() + fixture.detectChanges() + expect( + fixture.nativeElement.querySelector('.badge.show').textContent + ).toContain('Copied!') jest.advanceTimersByTime(3000) expect(component.copiedSlug()).toBeNull() + fixture.detectChanges() + expect(fixture.nativeElement.querySelector('.badge.show')).toBeNull() }) it('ignores copy requests for non-ready bundles', () => { diff --git a/src-ui/src/app/components/manage/share-links/share-link-bundle-list/share-link-bundle-list.component.ts b/src-ui/src/app/components/manage/share-links/share-link-bundle-list/share-link-bundle-list.component.ts index 0ad6aa1fa..a6d3c34f3 100644 --- a/src-ui/src/app/components/manage/share-links/share-link-bundle-list/share-link-bundle-list.component.ts +++ b/src-ui/src/app/components/manage/share-links/share-link-bundle-list/share-link-bundle-list.component.ts @@ -106,7 +106,6 @@ export class ShareLinkBundleListComponent setTimeout(() => { this.copiedSlug.set(null) }, 3000) - this.toastService.showInfo($localize`Share link copied to clipboard.`) } }