Decode tag input before updating domains

Co-authored-by: DerLinkman <62480600+DerLinkman@users.noreply.github.com>

data/web/inc/functions.mailbox.inc.php

@@ -842,11 +842,11 @@ function mailbox($_action, $_type, $_data = null, $_extra = null) {
               );
               continue;
             }
-            if (!hasDomainAccess($_SESSION['mailcow_cc_username'], $_SESSION['mailcow_cc_role'], $domain)) {
+            if (!hasDomainAccess($_SESSION['mailcow_cc_username'], $_SESSION['mailcow_cc_role'], $domain)) {
-              $_SESSION['return'][] = array(
+              $_SESSION['return'][] = array(
-                'type' => 'danger',
+                'type' => 'danger',
-                'log' => array(__FUNCTION__, $_action, $_type, $_data_log, $_attr),
+                'log' => array(__FUNCTION__, $_action, $_type, $_data_log, $_attr),
-                'msg' => 'access_denied'
+                'msg' => 'access_denied'
               );
               continue;
             }
@@ -2732,7 +2732,11 @@ function mailbox($_action, $_type, $_data = null, $_extra = null) {
                 $gal                  = (isset($_data['gal'])) ? intval($_data['gal']) : $is_now['gal'];
                 $description          = (!empty($_data['description']) && isset($_SESSION['acl']['domain_desc']) && $_SESSION['acl']['domain_desc'] == "1") ? $_data['description'] : $is_now['description'];
                 (int)$relayhost       = (isset($_data['relayhost']) && isset($_SESSION['acl']['domain_relayhost']) && $_SESSION['acl']['domain_relayhost'] == "1") ? intval($_data['relayhost']) : intval($is_now['relayhost']);
-                $tags                 = (is_array($_data['tags']) ? $_data['tags'] : array());
+                $tags_raw             = isset($_data['tags']) ? $_data['tags'] : array();
+                $tags                 = is_array($tags_raw) ? $tags_raw : json_decode($tags_raw, true);
+                if (!is_array($tags)) {
+                  $tags = array();
+                }
               }
               else {
                 $_SESSION['return'][] = array(
@@ -2753,11 +2757,11 @@ function mailbox($_action, $_type, $_data = null, $_extra = null) {
                 ':domain' => $domain
               ));
               // save tags
-              foreach($tags as $index => $tag){
+              foreach($tags as $index => $tag){
-                if (empty($tag)) continue;
+                if (empty($tag)) continue;
-                if ($index > $GLOBALS['TAGGING_LIMIT']) {
+                if ($index > $GLOBALS['TAGGING_LIMIT']) {
-                  $_SESSION['return'][] = array(
+                  $_SESSION['return'][] = array(
-                    'type' => 'warning',
+                    'type' => 'warning',
                     'log' => array(__FUNCTION__, $_action, $_type, $_data_log, $_attr),
                     'msg' => array('tag_limit_exceeded', 'limit '.$GLOBALS['TAGGING_LIMIT'])
                   );
@@ -2769,6 +2773,8 @@ function mailbox($_action, $_type, $_data = null, $_extra = null) {
                   ':tag_name' => $tag,
                 ));
               }
+              $stmt = $pdo->prepare("UPDATE `domain` SET `modified` = NOW() WHERE `domain` = :domain");
+              $stmt->execute(array(':domain' => $domain));
 
               $_SESSION['return'][] = array(
                 'type' => 'success',
@@ -2791,7 +2797,11 @@ function mailbox($_action, $_type, $_data = null, $_extra = null) {
                 $maxquota             = (!empty($_data['maxquota'])) ? $_data['maxquota'] : ($is_now['max_quota_for_mbox'] / 1048576);
                 $quota                = (!empty($_data['quota'])) ? $_data['quota'] : ($is_now['max_quota_for_domain'] / 1048576);
                 $description          = (!empty($_data['description'])) ? $_data['description'] : $is_now['description'];
-                $tags                 = (is_array($_data['tags']) ? $_data['tags'] : array());
+                $tags_raw             = isset($_data['tags']) ? $_data['tags'] : array();
+                $tags                 = is_array($tags_raw) ? $tags_raw : json_decode($tags_raw, true);
+                if (!is_array($tags)) {
+                  $tags = array();
+                }
                 if ($relay_all_recipients == '1') {
                   $backupmx = '1';
                 }
@@ -2931,17 +2941,19 @@ function mailbox($_action, $_type, $_data = null, $_extra = null) {
                   );
                   break;
                 }
-                $stmt = $pdo->prepare("INSERT INTO `tags_domain` (`domain`, `tag_name`) VALUES (:domain, :tag_name)");
+                $stmt = $pdo->prepare("INSERT INTO `tags_domain` (`domain`, `tag_name`) VALUES (:domain, :tag_name)");
-                $stmt->execute(array(
+                $stmt->execute(array(
-                  ':domain' => $domain,
+                  ':domain' => $domain,
-                  ':tag_name' => $tag,
+                  ':tag_name' => $tag,
-                ));
+                ));
-              }
+              }
-
+              $stmt = $pdo->prepare("UPDATE `domain` SET `modified` = NOW() WHERE `domain` = :domain");
-              $_SESSION['return'][] = array(
+              $stmt->execute(array(':domain' => $domain));
-                'type' => 'success',
+
-                'log' => array(__FUNCTION__, $_action, $_type, $_data_log, $_attr),
+              $_SESSION['return'][] = array(
-                'msg' => array('domain_modified', htmlspecialchars($domain))
+                'type' => 'success',
+                'log' => array(__FUNCTION__, $_action, $_type, $_data_log, $_attr),
+                'msg' => array('domain_modified', htmlspecialchars($domain))
               );
             }
           }
@@ -6108,14 +6120,15 @@ function mailbox($_action, $_type, $_data = null, $_extra = null) {
           else {
             $domains = $_data['domain'];
           }
-          $tags = $_data['tags'];
+          $tags_raw = isset($_data['tags']) ? $_data['tags'] : array();
+          $tags = is_array($tags_raw) ? $tags_raw : json_decode($tags_raw, true);
           if (!is_array($tags)) $tags = array();
 
-
+          $modifiedDomains = array();
-          $wasModified = false;
+          $wasModified = false;
-          foreach ($domains as $domain) {
+          foreach ($domains as $domain) {
-            if (!is_valid_domain_name($domain)) {
+            if (!is_valid_domain_name($domain)) {
-              $_SESSION['return'][] = array(
+              $_SESSION['return'][] = array(
                 'type' => 'danger',
                 'log' => array(__FUNCTION__, $_action, $_type, $_data_log, $_attr),
                 'msg' => 'domain_invalid'
@@ -6128,27 +6141,44 @@ function mailbox($_action, $_type, $_data = null, $_extra = null) {
                 'log' => array(__FUNCTION__, $_action, $_type, $_data_log, $_attr),
                 'msg' => 'access_denied'
               );
-              return false;
+              return false;
             }
 
-            foreach($tags as $tag){
+            $domainModified = false;
-              // delete tag
+            foreach($tags as $tag){
-              $wasModified = true;
+              // delete tag
-              $stmt = $pdo->prepare("DELETE FROM `tags_domain` WHERE `domain` = :domain AND `tag_name` = :tag_name");
+              $domainModified = true;
-              $stmt->execute(array(
+              $wasModified = true;
-                ':domain' => $domain,
+              $stmt = $pdo->prepare("DELETE FROM `tags_domain` WHERE `domain` = :domain AND `tag_name` = :tag_name");
-                ':tag_name' => $tag,
+              $stmt->execute(array(
-              ));
+                ':domain' => $domain,
-            }
+                ':tag_name' => $tag,
-          }
+              ));
-
+            }
-          if (!$wasModified) return false;
+            if ($domainModified) {
-          $_SESSION['return'][] = array(
+              $modifiedDomains[] = $domain;
-            'type' => 'success',
+            }
-            'log' => array(__FUNCTION__, $_action, $_type, $_data_log, $_attr),
+          }
-            'msg' => array('domain_modified', $domain)
+
-          );
+          if (!$wasModified) return false;
-        break;
+          if (!empty($modifiedDomains)) {
+            $placeholders = array();
+            $params = array();
+            foreach ($modifiedDomains as $idx => $modifiedDomain) {
+              $placeholders[] = ":domain".$idx;
+              $params[":domain".$idx] = $modifiedDomain;
+            }
+            $stmt = $pdo->prepare("UPDATE `domain` SET `modified` = NOW() WHERE `domain` IN (".implode(',', $placeholders).")");
+            $stmt->execute($params);
+            $modifiedDomains = array_map('htmlspecialchars', $modifiedDomains);
+          }
+          $modifiedDomains = (empty($modifiedDomains)) ? array('-') : $modifiedDomains;
+          $_SESSION['return'][] = array(
+            'type' => 'success',
+            'log' => array(__FUNCTION__, $_action, $_type, $_data_log, $_attr),
+            'msg' => array('domain_modified', implode(', ', $modifiedDomains))
+          );
+        break;
         case 'tags_mailbox':
           if (!is_array($_data['username'])) {
             $usernames = array();