The edit action stores the setting as ignore_ssl_error, but the get
action cast and defaulted ignore_ssl_errors. The stored value was
returned as a string and LDAP setups got an extra ignore_ssl_errors
field that was always false.
Co-authored-by: diko <108140792+admins-little-helper@users.noreply.github.com>
DataTables removes the top padding of the first entry in the expanded
row, but mailcow's 0.5em padding left 7px under the last entry, so the
list had 7px of space above and 15px below and the last entry (often
Tags) looked taller than the others. Drop the last entry's bottom
padding as well.
Signed-off-by: Moritz Stückler <moritz@bitbetter.de>
- Use the normal cursor on non-orderable headers. The expand column
header kept a pointer cursor from sorting_asc although clicking it
does nothing.
- Let icons in badges inherit the badge font size, like .btn .bi, and
keep their glyph from adding line height. The global 12pt icon size
made e.g. the "SSO @" badge in Last mail login taller than the IMAP
and SMTP badges next to it. Tag badges keep their 12px icon.
- Drop the vertical margin of tag badges inside tables. It is meant for
the tag editor in edit forms and made the Tags entry of the expanded
row taller than the others.
- Center tag badge captions: the 12px tag icon stretched the 10.5px
badge line and pushed the caption below center.
Signed-off-by: Moritz Stückler <moritz@bitbetter.de>
- Center the +/- glyph in the expand control: its line-height (1.25em)
was larger than the 1em box, pushing the glyph down. Derive the box's
margin-top from its size so it is centered in the row (desktop and
the larger mobile variant).
- Hide sort arrows on non-orderable headers. The default initial order
targets column 0, the expand column, which got a sorting_asc arrow
and arrow padding although it cannot be sorted.
- Center row checkboxes level with the expand control by using
Bootstrap's 0.25em margin-top instead of a fixed 7px.
Signed-off-by: Moritz Stückler <moritz@bitbetter.de>
Caption the "RL" column "Rate limit" using the existing translated
edit.ratelimit string, and shorten "Max. size of a mailbox" to
"Max. mailbox size" (en-gb only; the key is only used for this column).
Signed-off-by: Moritz Stückler <moritz@bitbetter.de>
The forced TFA enrollment form submitted the raw credential JSON in the
'token' field, which set_tfa()'s webauthn case never reads. It expects the
parsed \['registration'] object that only the JSON API builds, so the
form POST inserted a row with an empty keyHandle and a NULL publicKey while
still reporting success. Every WebAuthn 2FA login then failed, because
webauthn-tfa-get-args sent an empty credential id in allowCredentials.
- base.twig: POST the attestation to /api/v1/add/webauthn-tfa-registration
like the regular WebAuthn modal does
- functions.inc.php: refuse incomplete WebAuthn registrations
- lang.en-gb.json: message for the new guard
The extended_sender_acl field sat inside the
`{% if not result.authsource or result.authsource == 'mailcow' %}` block
that hides the local password fields for mailboxes authenticating against
an external identity provider. As a result the "External sender addresses"
input was not rendered at all for keycloak / generic-oidc / ldap mailboxes,
even for a full admin, so those addresses could neither be reviewed nor
edited in the UI while the underlying sender_acl rows stayed active.
Extended sender ACLs are unrelated to local password management. Move the
field out of that block; it stays gated by acl.extend_sender_acl as intended.
Fixes#7365
FreddleSpl0it
Junker der Provinzanddiko
Jorge Lobo
milkmakerandciri-cuervo
Moritz Stückler
Bilal Zahid
Stephen Ritz