Merge branch 'perf/binary-reader-byteswap' into perf/msgpack-scalar-runs

Signed-off-by: Niels Lohmann <mail@nlohmann.me>

include/nlohmann/detail/input/binary_reader.hpp

@@ -1148,10 +1148,8 @@ class binary_reader
         }
     }
 
-    /// read a single- or double-precision float (kept out of
-    /// parse_cbor_value, which is inlined into parse_cbor_internal)
+    /// read a single- or double-precision float
     template<typename NumberType>
-    JSON_HEDLEY_NEVER_INLINE
     bool get_cbor_float()
     {
         NumberType number{};
@@ -4364,7 +4362,12 @@ class binary_reader
     `char_traits<char_type>::eof()` in that case.
 
     @return character read from the input
+
+    @note always inlined: GCC otherwise stops inlining the stream adapter's
+          get_character() into parse_cbor_internal once that function grows
+          (+0.45 % instructions for CBOR from a std::istringstream with GCC 13)
     */
+    JSON_HEDLEY_ALWAYS_INLINE
     char_int_type get()
     {
         ++chars_read;

single_include/nlohmann/json.hpp

@@ -18925,10 +18925,8 @@ class binary_reader
         }
     }
 
-    /// read a single- or double-precision float (kept out of
-    /// parse_cbor_value, which is inlined into parse_cbor_internal)
+    /// read a single- or double-precision float
     template<typename NumberType>
-    JSON_HEDLEY_NEVER_INLINE
     bool get_cbor_float()
     {
         NumberType number{};
@@ -22141,7 +22139,12 @@ class binary_reader
     `char_traits<char_type>::eof()` in that case.
 
     @return character read from the input
+
+    @note always inlined: GCC otherwise stops inlining the stream adapter's
+          get_character() into parse_cbor_internal once that function grows
+          (+0.45 % instructions for CBOR from a std::istringstream with GCC 13)
     */
+    JSON_HEDLEY_ALWAYS_INLINE
     char_int_type get()
     {
         ++chars_read;

tests/src/unit-msgpack.cpp

@@ -2275,7 +2275,8 @@ TEST_CASE("MessagePack arrays of scalars from contiguous and non-contiguous inpu
         std::string bytewise_error;
         try
         {
-            static_cast<void>(json::from_msgpack(contiguous));
+            json _;
+            _ = json::from_msgpack(contiguous);
         }
         catch (const json::parse_error& e)
         {
@@ -2283,7 +2284,8 @@ TEST_CASE("MessagePack arrays of scalars from contiguous and non-contiguous inpu
         }
         try
         {
-            static_cast<void>(json::from_msgpack(bytewise.begin(), bytewise.end()));
+            json _;
+            _ = json::from_msgpack(bytewise.begin(), bytewise.end());
         }
         catch (const json::parse_error& e)
         {