From f9b9b303cbeadb09df4772690ef2a2d2e972dd61 Mon Sep 17 00:00:00 2001 From: Niels Lohmann Date: Wed, 30 Sep 2026 10:01:21 +0200 Subject: [PATCH] Fix docset README's non-existent make target and stale fallback URL The README told readers to run `make nlohmann_json.docset`, but the Makefile's targets are `all`, `JSON_for_Modern_C++.docset` and `install_docset_zeal`; the documented command has failed with "No rule to make target" since #2967 (2021). Point the README at the real target and folder name. Info.plist's DashDocSetFallbackURL also still pointed at the old nlohmann.github.io/json/ URL instead of the canonical https://json.nlohmann.me/ from mkdocs.yml's site_url. Leave list_missing_pages/list_removed_paths alone: they may become redundant once #5638's check_docset() lands, which is a follow-up. Part of #5718 Signed-off-by: Niels Lohmann --- docs/docset/Info.plist | 2 +- docs/docset/README.md | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/docset/Info.plist b/docs/docset/Info.plist index 772ec08af..8f63bc5dd 100644 --- a/docs/docset/Info.plist +++ b/docs/docset/Info.plist @@ -13,7 +13,7 @@ dashIndexFilePath index.html DashDocSetFallbackURL - https://nlohmann.github.io/json/ + https://json.nlohmann.me/ isJavaScriptEnabled diff --git a/docs/docset/README.md b/docs/docset/README.md index 79a778eb8..9d962a91c 100644 --- a/docs/docset/README.md +++ b/docs/docset/README.md @@ -7,10 +7,11 @@ documentation browsers like [Dash](https://kapeli.com/dash), [Velocity](https:// The docset can be created with ```sh -make nlohmann_json.docset +make JSON_for_Modern_C++.docset ``` -The generated folder `nlohmann_json.docset` can then be opened in the documentation browser. +The generated folder `JSON_for_Modern_C++.docset` can then be opened in the documentation browser. `make all` builds a +`JSON_for_Modern_C++.tgz` archive instead, and `make install_docset_zeal` installs the docset for Zeal directly. A recent version is also part of the [Dash user contributions](https://github.com/Kapeli/Dash-User-Contributions/tree/master/docsets/JSON_for_Modern_C%2B%2B).