From eea976435bb5b75e26a54daa4b18b4acd20ea10d Mon Sep 17 00:00:00 2001 From: Niels Lohmann Date: Wed, 2 Sep 2026 09:18:26 +0200 Subject: [PATCH] Re-enable the array and binary custom-container tests unit-custom-array-type.cpp and unit-custom-binary-type.cpp were still guarded behind JSON_BISECT_CUSTOM_CONTAINER_TESTS from bisecting the AppVeyor failure fixed in 7c39f3227, which was unrelated to either file. The macro was never defined, so none of these tests actually ran in CI. Verified locally with clang++ and g++ under C++17 and C++20 before removing the guards. Signed-off-by: Niels Lohmann --- tests/src/unit-custom-array-type.cpp | 8 -------- tests/src/unit-custom-binary-type.cpp | 8 -------- 2 files changed, 16 deletions(-) diff --git a/tests/src/unit-custom-array-type.cpp b/tests/src/unit-custom-array-type.cpp index f10455f15..00606c6e0 100644 --- a/tests/src/unit-custom-array-type.cpp +++ b/tests/src/unit-custom-array-type.cpp @@ -17,12 +17,6 @@ #include #include -// TEMPORARY: this translation unit is disabled to narrow down an AppVeyor -// failure on MSVC 2015/2017 whose build log this environment cannot reach. -// The macro is deliberately never defined; the guard is removed again as soon -// as the cause is known. -#ifdef JSON_BISECT_CUSTOM_CONTAINER_TESTS - namespace { @@ -154,5 +148,3 @@ TEST_CASE("array type without at()") CHECK(j.at(no_at_json::json_pointer("/1")) == 2); CHECK_THROWS_AS(j.at(no_at_json::json_pointer("/3")), no_at_json::out_of_range); } - -#endif diff --git a/tests/src/unit-custom-binary-type.cpp b/tests/src/unit-custom-binary-type.cpp index b7718a769..d357ec9a3 100644 --- a/tests/src/unit-custom-binary-type.cpp +++ b/tests/src/unit-custom-binary-type.cpp @@ -21,12 +21,6 @@ #include #endif -// TEMPORARY: this translation unit is disabled to narrow down an AppVeyor -// failure on MSVC 2015/2017 whose build log this environment cannot reach. -// The macro is deliberately never defined; the guard is removed again as soon -// as the cause is known. -#ifdef JSON_BISECT_CUSTOM_CONTAINER_TESTS - namespace { @@ -83,5 +77,3 @@ TEST_CASE("binary type whose value type is not std::uint8_t") } #endif } - -#endif