From e1dfc6581449f7f027e13eb62b25e3cf0cb1a582 Mon Sep 17 00:00:00 2001 From: Niels Lohmann Date: Mon, 31 Aug 2026 14:14:05 +0000 Subject: [PATCH] Temporarily disable the new custom container tests AppVeyor is the only CI that builds MSVC 2015 and 2017, and it has now rejected three heads of this branch. Its build log is not reachable from where this is being worked on, so the verdict is a single bit and the cause has to be narrowed down by bisection. Everything else stays: the library changes, the reduced alt_string, and the unflatten() tests. If AppVeyor passes with these three translation units disabled, the cause is one of the six basic_json instantiations they add; if it fails, it is in the library. Either way this commit is reverted. Signed-off-by: Niels Lohmann --- tests/src/unit-custom-array-type.cpp | 7 +++++++ tests/src/unit-custom-binary-type.cpp | 7 +++++++ tests/src/unit-custom-object-type.cpp | 7 +++++++ 3 files changed, 21 insertions(+) diff --git a/tests/src/unit-custom-array-type.cpp b/tests/src/unit-custom-array-type.cpp index 00606c6e0..be25469b0 100644 --- a/tests/src/unit-custom-array-type.cpp +++ b/tests/src/unit-custom-array-type.cpp @@ -17,6 +17,11 @@ #include #include +// TEMPORARY: this translation unit is disabled to narrow down an AppVeyor +// failure on MSVC 2015/2017 whose build log this environment cannot reach. +// The guard is removed again as soon as the cause is known. +#if 0 + namespace { @@ -148,3 +153,5 @@ TEST_CASE("array type without at()") CHECK(j.at(no_at_json::json_pointer("/1")) == 2); CHECK_THROWS_AS(j.at(no_at_json::json_pointer("/3")), no_at_json::out_of_range); } + +#endif diff --git a/tests/src/unit-custom-binary-type.cpp b/tests/src/unit-custom-binary-type.cpp index d357ec9a3..e7191b296 100644 --- a/tests/src/unit-custom-binary-type.cpp +++ b/tests/src/unit-custom-binary-type.cpp @@ -21,6 +21,11 @@ #include #endif +// TEMPORARY: this translation unit is disabled to narrow down an AppVeyor +// failure on MSVC 2015/2017 whose build log this environment cannot reach. +// The guard is removed again as soon as the cause is known. +#if 0 + namespace { @@ -77,3 +82,5 @@ TEST_CASE("binary type whose value type is not std::uint8_t") } #endif } + +#endif diff --git a/tests/src/unit-custom-object-type.cpp b/tests/src/unit-custom-object-type.cpp index c27c5ea23..5bf12797f 100644 --- a/tests/src/unit-custom-object-type.cpp +++ b/tests/src/unit-custom-object-type.cpp @@ -17,6 +17,11 @@ #include #include +// TEMPORARY: this translation unit is disabled to narrow down an AppVeyor +// failure on MSVC 2015/2017 whose build log this environment cannot reach. +// The guard is removed again as soon as the cause is known. +#if 0 + namespace { @@ -189,3 +194,5 @@ TEST_CASE("object type without key_compare") CHECK(no_key_compare_json(converted) == j); } } + +#endif