From d974c4a64f71e0fae2424c076381591fb4bd38a7 Mon Sep 17 00:00:00 2001 From: Niels Lohmann Date: Thu, 8 Oct 2026 16:14:00 +0200 Subject: [PATCH] Silence -Wweak-vtables for the SAX event loggers The loggers moved from anonymous namespaces in the test files into sax_event_loggers.hpp, so clang now warns that their vtables are emitted in every translation unit. Signed-off-by: Niels Lohmann --- tests/src/sax_event_loggers.hpp | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/tests/src/sax_event_loggers.hpp b/tests/src/sax_event_loggers.hpp index 0d18e4f7b..e39ad9e56 100644 --- a/tests/src/sax_event_loggers.hpp +++ b/tests/src/sax_event_loggers.hpp @@ -16,6 +16,13 @@ #include +// the loggers are defined in this header only, so their vtables are emitted in +// every test that includes it +#if defined(__clang__) + #pragma clang diagnostic push + #pragma clang diagnostic ignored "-Wweak-vtables" +#endif + namespace utils { /// a SAX event consumer that records every event it receives as a @@ -172,3 +179,7 @@ struct SaxEventLoggerExitAfterStartArray : public SaxEventLogger } }; } // namespace utils + +#if defined(__clang__) + #pragma clang diagnostic pop +#endif