From d8dfc0d0f9cf1097dd2768e3a8770bbddcc0aa08 Mon Sep 17 00:00:00 2001 From: Niels Lohmann Date: Thu, 8 Oct 2026 16:21:59 +0200 Subject: [PATCH] Fix unused-result warnings in the contains and parse_error examples (#5788) contains(json_pointer) is marked JSON_HEDLEY_WARN_UNUSED_RESULT since #5477, and parse() has been for longer. The contains example ignored the result in two try blocks waiting for a parse_error that contains() never throws, so they printed nothing; print the result for those pointers instead. Signed-off-by: Niels Lohmann --- .../docs/examples/contains__json_pointer.cpp | 26 ++++--------------- .../examples/contains__json_pointer.output | 2 ++ docs/mkdocs/docs/examples/parse_error.cpp | 2 +- 3 files changed, 8 insertions(+), 22 deletions(-) diff --git a/docs/mkdocs/docs/examples/contains__json_pointer.cpp b/docs/mkdocs/docs/examples/contains__json_pointer.cpp index 14d8514b4..985ad9ec5 100644 --- a/docs/mkdocs/docs/examples/contains__json_pointer.cpp +++ b/docs/mkdocs/docs/examples/contains__json_pointer.cpp @@ -19,25 +19,9 @@ int main() << j.contains("/array/1"_json_pointer) << '\n' << j.contains("/array/-"_json_pointer) << '\n' << j.contains("/array/4"_json_pointer) << '\n' - << j.contains("/baz"_json_pointer) << std::endl; - - try - { - // try to use an array index with leading '0' - j.contains("/array/01"_json_pointer); - } - catch (const json::parse_error& e) - { - std::cout << e.what() << '\n'; - } - - try - { - // try to use an array index that is not a number - j.contains("/array/one"_json_pointer); - } - catch (const json::parse_error& e) - { - std::cout << e.what() << '\n'; - } + << j.contains("/baz"_json_pointer) << '\n' + // an array index with a leading '0' is not found + << j.contains("/array/01"_json_pointer) << '\n' + // an array index that is not a number is not found + << j.contains("/array/one"_json_pointer) << std::endl; } diff --git a/docs/mkdocs/docs/examples/contains__json_pointer.output b/docs/mkdocs/docs/examples/contains__json_pointer.output index dd1eb38c1..b989a7c30 100644 --- a/docs/mkdocs/docs/examples/contains__json_pointer.output +++ b/docs/mkdocs/docs/examples/contains__json_pointer.output @@ -5,3 +5,5 @@ true false false false +false +false diff --git a/docs/mkdocs/docs/examples/parse_error.cpp b/docs/mkdocs/docs/examples/parse_error.cpp index ce15ebe22..2f73ac65f 100644 --- a/docs/mkdocs/docs/examples/parse_error.cpp +++ b/docs/mkdocs/docs/examples/parse_error.cpp @@ -8,7 +8,7 @@ int main() try { // parsing input with a syntax error - json::parse("[1,2,3,]"); + json j = json::parse("[1,2,3,]"); } catch (const json::parse_error& e) {