Merge branch 'json-view/11-view-access' into json-view/12-view-values

Signed-off-by: Niels Lohmann <mail@nlohmann.me>

include/nlohmann/detail/view/string_ref.hpp

@@ -40,6 +40,8 @@ class string_ref
     using const_iterator = const char*;
 
     string_ref() noexcept = default;
+    // s must be null-terminated, as for std::string_view(const char*)
+    // flawfinder: ignore
     string_ref(const char* s) : m_data(s), m_size(std::strlen(s)) {} // NOLINT(google-explicit-constructor,hicpp-explicit-conversions)
     string_ref(const char* s, std::size_t n) noexcept : m_data(s), m_size(n) {}
     template<typename Traits, typename Alloc>

include/nlohmann/json_view.hpp

@@ -751,6 +751,7 @@ class basic_json_document
 
     /// parse into this document, reusing its memory
     template<typename InputType>
+    // flawfinder: ignore (a member function, not POSIX read())
     void read(InputType&& input,
               const bool allow_exceptions = true,
               const bool ignore_comments = false,
@@ -917,6 +918,8 @@ class basic_json_document
             return;
         }
         const char* cs = reinterpret_cast<const char*>(s); // NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
+        // C strings are null-terminated, as for json::parse(const char*)
+        // flawfinder: ignore
         build(cs, std::strlen(cs), ae, c, tc, false, true);
     }
 

single_include/nlohmann/json_view.hpp

@@ -2607,6 +2607,8 @@ class string_ref
     using const_iterator = const char*;
 
     string_ref() noexcept = default;
+    // s must be null-terminated, as for std::string_view(const char*)
+    // flawfinder: ignore
     string_ref(const char* s) : m_data(s), m_size(std::strlen(s)) {} // NOLINT(google-explicit-constructor,hicpp-explicit-conversions)
     string_ref(const char* s, std::size_t n) noexcept : m_data(s), m_size(n) {}
     template<typename Traits, typename Alloc>
@@ -3488,6 +3490,7 @@ class basic_json_document
 
     /// parse into this document, reusing its memory
     template<typename InputType>
+    // flawfinder: ignore (a member function, not POSIX read())
     void read(InputType&& input,
               const bool allow_exceptions = true,
               const bool ignore_comments = false,
@@ -3654,6 +3657,8 @@ class basic_json_document
             return;
         }
         const char* cs = reinterpret_cast<const char*>(s); // NOLINT(cppcoreguidelines-pro-type-reinterpret-cast)
+        // C strings are null-terminated, as for json::parse(const char*)
+        // flawfinder: ignore
         build(cs, std::strlen(cs), ae, c, tc, false, true);
     }