🚨 fix warning

include/nlohmann/detail/input/json_sax.hpp

@@ -353,7 +353,7 @@ class json_sax_dom_callback_parser
     using parse_event_t = typename BasicJsonType::parse_event_t;
 
     json_sax_dom_callback_parser(BasicJsonType& r,
-                                 const parser_callback_t cb,
+                                 const parser_callback_t& cb,
                                  const bool allow_exceptions_ = true)
         : root(r), callback(cb), allow_exceptions(allow_exceptions_)
     {

include/nlohmann/detail/input/parser.hpp

@@ -69,7 +69,7 @@ class parser
   public:
     /// a parser reading from an input adapter
     explicit parser(InputAdapterType&& adapter,
-                    const parser_callback_t<BasicJsonType> cb = nullptr,
+                    const parser_callback_t<BasicJsonType>& cb = nullptr,
                     const bool allow_exceptions_ = true,
                     const bool skip_comments = false)
         : callback(cb)

include/nlohmann/detail/output/output_adapters.hpp

@@ -31,7 +31,7 @@ template<typename CharType> struct output_adapter_protocol
 {
     virtual void write_character(CharType c) = 0;
     virtual void write_characters(const CharType* s, std::size_t length) = 0;
-    virtual ~output_adapter_protocol() = default;
+    virtual ~output_adapter_protocol();
 
     output_adapter_protocol() = default;
     output_adapter_protocol(const output_adapter_protocol&) = default;
@@ -40,6 +40,10 @@ template<typename CharType> struct output_adapter_protocol
     output_adapter_protocol& operator=(output_adapter_protocol&&) noexcept = default;
 };
 
+// explicitly default the destructor to fix portability-template-virtual-member-function
+template<typename CharType>
+output_adapter_protocol<CharType>::~output_adapter_protocol() = default;
+
 /// a type to simplify interfaces
 template<typename CharType>
 using output_adapter_t = std::shared_ptr<output_adapter_protocol<CharType>>;