From acca7575ce7212b97de0b5a625ca7f5d15091837 Mon Sep 17 00:00:00 2001 From: Niels Lohmann Date: Wed, 8 Jul 2026 15:14:59 +0200 Subject: [PATCH] Fix issue reference in std::optional test comment Update the comment in the null section test to reference #5246 instead of placeholder #XXXX, clarifying where the direct-init/copy-init limitation is tracked. Signed-off-by: Niels Lohmann --- tests/src/unit-conversions.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/src/unit-conversions.cpp b/tests/src/unit-conversions.cpp index 0aac264ab..5a7353eae 100644 --- a/tests/src/unit-conversions.cpp +++ b/tests/src/unit-conversions.cpp @@ -1778,7 +1778,7 @@ TEST_CASE("std::optional") // constructible from T, and T is constructible from basic_json via the // operator); there is no SFINAE path that distinguishes "call from inside // std::optional's constructor" from "direct call". Use get>() - // or get_to() instead for correct null handling. See json#4864 and #XXXX. + // or get_to() instead for correct null handling. See #4864 and #5246. CHECK_THROWS_AS(std::optional(j_null), json::type_error); CHECK_THROWS_AS(std::optional(j_null), json::type_error); }