From a0fe86d087d598455f2c6160deb441f9082639ec Mon Sep 17 00:00:00 2001 From: Niels Lohmann Date: Wed, 30 Sep 2026 09:56:53 +0200 Subject: [PATCH] Fix stale #include lines in the output headers output_adapters.hpp included and for std::copy and std::back_inserter, which have not been used there since #3569 (2022). serializer.hpp included for std::reverse (also unused), for labs/isnan/signbit (only std::isfinite is used) and for std::move (nothing from is used there), while using std::next without including at all, relying on getting it transitively through output_adapters.hpp's own stale . Drop the unused includes, add for std::next, and correct the remaining include comments. Both headers still compile standalone with -Wall -Wextra -Werror. Part of #5709 Signed-off-by: Niels Lohmann --- include/nlohmann/detail/output/output_adapters.hpp | 2 -- include/nlohmann/detail/output/serializer.hpp | 6 +++--- single_include/nlohmann/json.hpp | 8 +++----- 3 files changed, 6 insertions(+), 10 deletions(-) diff --git a/include/nlohmann/detail/output/output_adapters.hpp b/include/nlohmann/detail/output/output_adapters.hpp index 7eb73121c..6755878cc 100644 --- a/include/nlohmann/detail/output/output_adapters.hpp +++ b/include/nlohmann/detail/output/output_adapters.hpp @@ -8,9 +8,7 @@ #pragma once -#include // copy #include // size_t -#include // back_inserter #include // shared_ptr, make_shared #include // basic_string #include // move diff --git a/include/nlohmann/detail/output/serializer.hpp b/include/nlohmann/detail/output/serializer.hpp index 118af5dc7..aa94ea7b5 100644 --- a/include/nlohmann/detail/output/serializer.hpp +++ b/include/nlohmann/detail/output/serializer.hpp @@ -9,18 +9,18 @@ #pragma once -#include // reverse, remove, fill, find, none_of, min +#include // remove, fill, find, none_of, min #include // array #include // localeconv, lconv -#include // labs, isfinite, isnan, signbit +#include // isfinite #include // size_t, ptrdiff_t #include // uint8_t #include // snprintf #include // memcpy, memset +#include // next #include // numeric_limits #include // string, char_traits #include // is_same -#include // move #include // vector #include diff --git a/single_include/nlohmann/json.hpp b/single_include/nlohmann/json.hpp index b88489a5c..18994919c 100644 --- a/single_include/nlohmann/json.hpp +++ b/single_include/nlohmann/json.hpp @@ -20146,9 +20146,7 @@ NLOHMANN_JSON_NAMESPACE_END -#include // copy #include // size_t -#include // back_inserter #include // shared_ptr, make_shared #include // basic_string #include // move @@ -22960,18 +22958,18 @@ NLOHMANN_JSON_NAMESPACE_END -#include // reverse, remove, fill, find, none_of, min +#include // remove, fill, find, none_of, min #include // array #include // localeconv, lconv -#include // labs, isfinite, isnan, signbit +#include // isfinite #include // size_t, ptrdiff_t #include // uint8_t #include // snprintf #include // memcpy, memset +#include // next #include // numeric_limits #include // string, char_traits #include // is_same -#include // move #include // vector // #include