From 911273162acb7f0f2fc1e593a10fdbbb068c83dd Mon Sep 17 00:00:00 2001 From: Niels Lohmann Date: Mon, 31 Aug 2026 21:05:28 +0000 Subject: [PATCH] Bisect the other way: only the object container tests The previous head touched only docs/, which AppVeyor's only_commits filter skips, so it produced no build and no status at all -- the pull request looked green without ever having been built on MSVC 2015 or 2017. Swap the guards instead of repeating that step: unit-custom-object-type.cpp is enabled and the array and binary translation units are disabled. AppVeyor already passed with all three disabled, so a failure here pins the cause on no_key_compare_json or void_erase_json, and a pass pins it on the array or binary file. Still temporary. Signed-off-by: Niels Lohmann --- tests/src/unit-custom-array-type.cpp | 8 ++++++++ tests/src/unit-custom-binary-type.cpp | 8 ++++++++ tests/src/unit-custom-object-type.cpp | 6 ------ 3 files changed, 16 insertions(+), 6 deletions(-) diff --git a/tests/src/unit-custom-array-type.cpp b/tests/src/unit-custom-array-type.cpp index 00606c6e0..f10455f15 100644 --- a/tests/src/unit-custom-array-type.cpp +++ b/tests/src/unit-custom-array-type.cpp @@ -17,6 +17,12 @@ #include #include +// TEMPORARY: this translation unit is disabled to narrow down an AppVeyor +// failure on MSVC 2015/2017 whose build log this environment cannot reach. +// The macro is deliberately never defined; the guard is removed again as soon +// as the cause is known. +#ifdef JSON_BISECT_CUSTOM_CONTAINER_TESTS + namespace { @@ -148,3 +154,5 @@ TEST_CASE("array type without at()") CHECK(j.at(no_at_json::json_pointer("/1")) == 2); CHECK_THROWS_AS(j.at(no_at_json::json_pointer("/3")), no_at_json::out_of_range); } + +#endif diff --git a/tests/src/unit-custom-binary-type.cpp b/tests/src/unit-custom-binary-type.cpp index d357ec9a3..b7718a769 100644 --- a/tests/src/unit-custom-binary-type.cpp +++ b/tests/src/unit-custom-binary-type.cpp @@ -21,6 +21,12 @@ #include #endif +// TEMPORARY: this translation unit is disabled to narrow down an AppVeyor +// failure on MSVC 2015/2017 whose build log this environment cannot reach. +// The macro is deliberately never defined; the guard is removed again as soon +// as the cause is known. +#ifdef JSON_BISECT_CUSTOM_CONTAINER_TESTS + namespace { @@ -77,3 +83,5 @@ TEST_CASE("binary type whose value type is not std::uint8_t") } #endif } + +#endif diff --git a/tests/src/unit-custom-object-type.cpp b/tests/src/unit-custom-object-type.cpp index ef1abface..64bbe2469 100644 --- a/tests/src/unit-custom-object-type.cpp +++ b/tests/src/unit-custom-object-type.cpp @@ -17,11 +17,6 @@ #include #include -// TEMPORARY: this translation unit is disabled to narrow down an AppVeyor -// failure on MSVC 2015/2017 whose build log this environment cannot reach. -// The macro is deliberately never defined; the guard is removed again as soon -// as the cause is known. -#ifdef JSON_BISECT_CUSTOM_CONTAINER_TESTS namespace { @@ -196,4 +191,3 @@ TEST_CASE("object type without key_compare") } } -#endif