mirror of
https://github.com/nlohmann/json.git
synced 2026-11-03 03:15:34 +00:00
Fix the red CI on develop: Visual Studio 2017 build of the BSON writer, Valgrind timeouts (#6009)
* CI: give the Valgrind tests a timeout of one hour Under Valgrind, test-json_view_builder_cpp11 and test-ordered_json_cpp11 took 1435 s and 1390 s on develop (ddc34f5), close to ctest's default timeout of 1500 s. On the next run (b2674a4) the whole job was about 10 % slower and both timed out, failing ci_test_valgrind on develop and on every PR based on it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N5NasAgbDGG28MqXjQvLqp Signed-off-by: Claude <noreply@anthropic.com> * BSON writer: drop the SFINAE guard that Visual Studio 2017 cannot deduce write_bson_document_single_pass() was a member template enabled by is_detected<sink_written_t, SinkType>. MSVC 19.16 (Visual Studio 2017) fails to deduce it through the class-scope alias template (C2672, C2783) when it compiles to_bson() and to_bon8(), so every Visual Studio 2017 job on AppVeyor fails since #5979. The guard is not needed: as a non-template member of the class template, the function is only instantiated when called, and its only caller is the write_bson_document() overload for sinks that have written(), which already calls oa.written() and oa.rewind() itself. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N5NasAgbDGG28MqXjQvLqp Signed-off-by: Claude <noreply@anthropic.com> --------- Signed-off-by: Claude <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
1 parent
b2674a4a2f
commit
76dbe8f9c9
3 files changed
+3
-3
No files matched your search
Generated
-1
@@ -30394,7 +30394,6 @@ class binary_writer
|
||||
nothing large has been written then, and the caller writes the
|
||||
document in two passes, which reports that error
|
||||
*/
|
||||
template<typename SinkType = OutputSinkType, typename std::enable_if<is_detected<sink_written_t, SinkType>::value, int>::type = 0>
|
||||
bool write_bson_document_single_pass(const BasicJsonType& document)
|
||||
{
|
||||
const std::size_t start = oa.written();
|
||||
|
||||
Reference in new issue
Block a user