From 626fdb098a66ebdaaecdc6be7c22930fe258e0a2 Mon Sep 17 00:00:00 2001 From: Niels Lohmann Date: Mon, 31 Aug 2026 19:17:15 +0000 Subject: [PATCH] Re-enable the array and binary container tests AppVeyor passed with all three new translation units disabled, so the library changes, the reduced alt_string, and the unflatten() tests are fine on MSVC 2015 and 2017; the cause is one of the six basic_json instantiations the new tests add. Bring back two of the three. If AppVeyor passes again, the cause is in unit-custom-object-type.cpp, which is the one still disabled; if it fails, it is in one of these two and needs one more split. Still temporary. Signed-off-by: Niels Lohmann --- tests/src/unit-custom-array-type.cpp | 8 -------- tests/src/unit-custom-binary-type.cpp | 8 -------- 2 files changed, 16 deletions(-) diff --git a/tests/src/unit-custom-array-type.cpp b/tests/src/unit-custom-array-type.cpp index f10455f15..00606c6e0 100644 --- a/tests/src/unit-custom-array-type.cpp +++ b/tests/src/unit-custom-array-type.cpp @@ -17,12 +17,6 @@ #include #include -// TEMPORARY: this translation unit is disabled to narrow down an AppVeyor -// failure on MSVC 2015/2017 whose build log this environment cannot reach. -// The macro is deliberately never defined; the guard is removed again as soon -// as the cause is known. -#ifdef JSON_BISECT_CUSTOM_CONTAINER_TESTS - namespace { @@ -154,5 +148,3 @@ TEST_CASE("array type without at()") CHECK(j.at(no_at_json::json_pointer("/1")) == 2); CHECK_THROWS_AS(j.at(no_at_json::json_pointer("/3")), no_at_json::out_of_range); } - -#endif diff --git a/tests/src/unit-custom-binary-type.cpp b/tests/src/unit-custom-binary-type.cpp index b7718a769..d357ec9a3 100644 --- a/tests/src/unit-custom-binary-type.cpp +++ b/tests/src/unit-custom-binary-type.cpp @@ -21,12 +21,6 @@ #include #endif -// TEMPORARY: this translation unit is disabled to narrow down an AppVeyor -// failure on MSVC 2015/2017 whose build log this environment cannot reach. -// The macro is deliberately never defined; the guard is removed again as soon -// as the cause is known. -#ifdef JSON_BISECT_CUSTOM_CONTAINER_TESTS - namespace { @@ -83,5 +77,3 @@ TEST_CASE("binary type whose value type is not std::uint8_t") } #endif } - -#endif