amorfo77/json
1
0
Fork 0
mirror of https://github.com/nlohmann/json.git synced 2026-09-05 15:57:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make diff() linear when an array shrinks (#5461)

Browse Source 
Signed-off-by: avionicharshit-byte <harshitavionic@gmail.com>
This commit is contained in:
Avionic Harshit
2026-09-05 09:52:53 +02:00
committed by GitHub
parent 137a40b9aa
commit 3c875683a5
3 changed files with 93 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
single_include/nlohmann/json.hpp
+6 -8
View File
@@ -26547,19 +26547,17 @@ class basic_json // NOLINT(cppcoreguidelines-special-member-functions,hicpp-spec
// We now reached the end of at least one array
// in a second pass, traverse the remaining elements
// remove my remaining elements
const auto end_index = static_cast<difference_type>(result.size());
while (i < source.size())
// remove my remaining elements, highest index first; appending
// in that order avoids the quadratic reinsertion done before
for (std::size_t j = source.size(); j > i; --j)
{
// add operations in reverse order to avoid invalid
// indices
result.insert(result.begin() + end_index, object(
result.push_back(object(
{
{"op", "remove"},
{"path", detail::concat<string_t>(path, '/', detail::to_string<string_t>(i))}
{"path", detail::concat<string_t>(path, '/', detail::to_string<string_t>(j - 1))}
}));
++i;
}
i = source.size();
// add other remaining elements
while (i < target.size())