Fix the clang-tidy 22 findings in json_view and its tests

Signed-off-by: Niels Lohmann <mail@nlohmann.me>
This commit is contained in:
Niels Lohmann committed 2026-10-11 10:28:13 +02:00
1 parent 9d43acd174
commit 0e2d8975a4
2 files changed
+4 -4

No files matched your search

+1 -1
View File
@@ -734,7 +734,7 @@ class basic_json_view
// the end is unknown: assume a few bytes per node, the output buffer // the end is unknown: assume a few bytes per node, the output buffer
// grows should the value be larger // grows should the value be larger
const auto nodes = static_cast<std::size_t>(document_data::after(m_node) - m_node); const auto nodes = static_cast<std::size_t>(document_data::after(m_node) - m_node);
return (std::min)(m_doc->size - m_node->off, static_cast<std::size_t>(1024) + nodes * 16); return (std::min)(m_doc->size - m_node->off, static_cast<std::size_t>(1024) + (nodes * 16));
} }
/// the value of the first member with this key, or a discarded view /// the value of the first member with this key, or a discarded view
+3 -3
View File
@@ -1509,10 +1509,10 @@ TEST_CASE("json_view dump")
{ {
chars += "\xC3\xA9"; chars += "\xC3\xA9";
} }
const json_document d = json_document::parse("{\"a\":\"" + chars + R"(","k\n":1})"); const json_document d = json_document::parse(R"({"a":")" + chars + R"(","k\n":1})");
const json expected = json::parse("\"" + chars + "\""); const json expected = json::parse("\"" + chars + "\"");
CHECK(d.root()["a"].dump(-1, ' ', true) == expected.dump(-1, ' ', true)); CHECK(d.root()["a"].dump(-1, ' ', true) == expected.dump(-1, ' ', true));
CHECK(d.root()["a"].dump(-1, ' ', true).size() == 2 + 5000 * 6); CHECK(d.root()["a"].dump(-1, ' ', true).size() == 2 + (5000 * 6));
} }
SECTION("streams and discarded views") SECTION("streams and discarded views")
@@ -1604,7 +1604,7 @@ TEST_CASE("json_view comparison")
// discarded values compare as basic_json's do // discarded values compare as basic_json's do
const json discarded(json::value_t::discarded); const json discarded(json::value_t::discarded);
CHECK((json_view() == json_view()) == (discarded == discarded)); // NOLINT(readability-container-size-empty): operator== is tested CHECK((json_view() == json_view()) == (discarded == discarded)); // NOLINT(readability-container-size-empty): operator== is tested
CHECK((json_view() == discarded) == (discarded == discarded)); CHECK((json_view() == discarded) == (discarded == discarded)); // NOLINT(readability-container-size-empty)
const json_document null_document = json_document::parse("null"); const json_document null_document = json_document::parse("null");
CHECK(!(json_view() == null_document.root())); // NOLINT(readability-container-size-empty) CHECK(!(json_view() == null_document.root())); // NOLINT(readability-container-size-empty)
CHECK(!(null_document.root() == discarded)); CHECK(!(null_document.root() == discarded));