From 5e8fc43857601b0f4b876930e791baa5774556d2 Mon Sep 17 00:00:00 2001 From: Geoff Bourne Date: Mon, 22 Nov 2021 20:51:30 -0600 Subject: [PATCH] fix: removed Java 8 constraint of Canyon server type #1129 --- README.md | 8 +++----- scripts/start-deployCanyon | 11 +++-------- 2 files changed, 6 insertions(+), 13 deletions(-) diff --git a/README.md b/README.md index 15b7095a..ccf4d957 100644 --- a/README.md +++ b/README.md @@ -502,17 +502,15 @@ A [Catserver](http://catserver.moe/) type server can be used with > **NOTE** Catserver only provides a single release stream, so `VERSION` is ignored -### Running an Canyon server +### Running a Canyon server [Canyon](https://github.com/canyonmodded/canyon) is a fork of CraftBukkit for Minecraft Beta 1.7.3. It includes multiple enhancements whilst also retaining compatibility with old Bukkit plugins and mods as much as possible. -e VERSION=b1.7.3 -e TYPE=CANYON -> **NOTE** only `VERSION=b1.7.3` is supported +> **NOTE** only `VERSION=b1.7.3` is supported. Since that version pre-dates the health check mechanism used by this image, that will need to be disabled by setting `DISABLE_HEALTHCHECK=true`. -> **NOTE** only Java 8 is supported - -By default the latest build will be used; however, a specific build number can be selected by setting `CANYON_BUILD`, such as +By default, the latest build will be used; however, a specific build number can be selected by setting `CANYON_BUILD`, such as -e CANYON_BUILD=11 diff --git a/scripts/start-deployCanyon b/scripts/start-deployCanyon index 4a31ac1c..a9ed0302 100755 --- a/scripts/start-deployCanyon +++ b/scripts/start-deployCanyon @@ -2,16 +2,11 @@ set -euo pipefail IFS=$'\n\t' -. ${SCRIPTS:-/}start-utils +# shellcheck source=start-utils +. "${SCRIPTS:-/}start-utils" isDebugging && set -x -: ${CANYON_BUILD:=lastSuccessfulBuild} -JAVA_VER=$(java -version 2>&1 | head -1 | cut -d'"' -f2 | sed '/^1\./s///' | cut -d'.' -f1) - -if [ "${JAVA_VER}" != "8" ]; then - log "ERROR: Canyon server type only supports Java version 8" - exit 1 -fi +: "${CANYON_BUILD:=lastSuccessfulBuild}" if [ "${VERSION}" != "b1.7.3" ]; then log "ERROR: Canyon server type only supports VERSION=b1.7.3"